Skip to content

fix: default coder image tag #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: default coder image tag #3764

wants to merge 2 commits into from

Conversation

ericpaulsen
Copy link
Member

this PR fixes the default Coder image tag in the Helm chart. it is currently set to 0.1.0, which does not exist.

below is the current behavior, using the default values.yaml file:

Failed to pull image "ghcr.io/coder/coder:v0.1.0": rpc error: code = NotFound desc = failed to pull and unpack image "ghcr.io/coder/coder:v0.1.0": failed to resolve reference "ghcr.io/coder/coder:v0.1.0": ghcr.io/coder/coder:v0.1.0: not found

I've set coder.image.tag to default to latest, and updated the {{.Chart.AppVersion}} to be 0.8.9, our latest release.

@ericpaulsen ericpaulsen self-assigned this Aug 30, 2022
kylecarbs
kylecarbs approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to change this on every version, which seems bad. Fixing it for now is better than nothing though!

deansheather
deansheather reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be set properly in the released helm packages. I'll make a change to fail the helm deployment if the version is 0.1.0 and the tag isn't set.

@ericpaulsen
Copy link
Member Author

closing in favor of @deansheather upcoming PR:

The version should be set properly in the released helm packages. I'll make a change to fail the helm deployment if the version is 0.1.0 and the tag isn't set.

@deansheather deansheather mentioned this pull request Aug 31, 2022
Merged
@github-actions github-actions bot deleted the fix-image-tag branch March 1, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather left review comments

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@ericpaulsen ericpaulsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericpaulsen @kylecarbs @deansheather