Skip to content

fix: Scope error to test functions to fix TestFeaturesService race #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix: Scope error to test functions to fix TestFeaturesService race #3765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Scope error to test functions to fix TestFeaturesService race 
Fixes #3747.
  • Loading branch information
@kylecarbs
kylecarbs committed Aug 30, 2022
commit 1d47765350eddca48edc6484d4510c98bcb05558
4 changes: 2 additions & 2 deletions enterprise/coderd/features_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func TestFeaturesService_EntitlementsAPI(t *testing.T) {
auditLogs: entitlement{entitled},
},
}
_, err = db.InsertUser(ctx, database.InsertUserParams{
_, err := db.InsertUser(ctx, database.InsertUserParams{
ID: uuid.UUID{},
Email: "",
Username: "",
Expand Down Expand Up @@ -136,7 +136,7 @@ func TestFeaturesService_EntitlementsAPI(t *testing.T) {
},
}
for i := byte(0); i < 5; i++ {
_, err = db.InsertUser(ctx, database.InsertUserParams{
_, err := db.InsertUser(ctx, database.InsertUserParams{
ID: uuid.UUID{i},
Email: "",
Username: "",
Expand Down