-
Notifications
You must be signed in to change notification settings - Fork 894
feat: Implement (but not enforce) CSRF for FE requests #3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
52c7575
feat: Implement CSRF in cli client and FE api
Emyrk 642a29f
Make fmt
Emyrk 37c0ba8
const vs let
Emyrk c774fcc
Fix lint error
presleyp 3c75967
remove bad console log
Emyrk ab48b4a
Add CSRF token in header
Emyrk 51d856e
Log error if token content is null
presleyp c8c8be0
Merge branch 'stevenmasley/csrf' of github.com:coder/coder into steve…
presleyp b03610b
Fix dev server csrf with hardcoded value
Emyrk e798e11
Do not error log in JS unit test
Emyrk 1c4810a
Make fmt on js files
Emyrk a6fdac8
Fix agent token checking
Emyrk a343da9
Fix unit test
Emyrk dd80cc9
Check auth cookie exists
Emyrk 08e76d4
Fix test auth
Emyrk 0aae08a
Fix logout test
Emyrk 3116964
Merge remote-tracking branch 'origin/main' into stevenmasley/csrf
Emyrk 10b4296
Fix merge issues
Emyrk 7177909
fixup! Fix merge issues
Emyrk 633118e
Make unit test use correct session value
Emyrk 5662a55
puppeteer does not have document defined
Emyrk 86b9ecf
Make fmt
Emyrk ecaf61f
Update wireguard dep
Emyrk 484fe2b
Add comment about BE cookie
Emyrk b18ea2e
chore: Ensure multiple version compatibility
Emyrk b97225f
Merge remote-tracking branch 'origin/main' into stevenmasley/csrf
Emyrk 3f1eedf
Do not enforce CSRF
Emyrk 8f367d2
Add nolint
Emyrk 85dcbfd
Account for devurl cookie
Emyrk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make fmt on js files
- Loading branch information
commit 1c4810ad65935b02bccf23a358d0a4c2596c8c03
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bummer we have to do this because of Jest but I don't know a better way lol thanks for adding a comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unfortunate :/