Skip to content

fix: Add latency-check for DERP over HTTP(s) #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2022
Merged

fix: Add latency-check for DERP over HTTP(s) #3788

merged 3 commits into from
Sep 1, 2022

Conversation

kylecarbs
Copy link
Member

This fixes scenarios where latency wasn't being reported if
a connection had UDP entirely blocked.

@kylecarbs kylecarbs self-assigned this Sep 1, 2022
@kylecarbs kylecarbs requested a review from ammario September 1, 2022 03:29
@kylecarbs
fix: Add latency-check for DERP over HTTP(s)
8afca6c 
This fixes scenarios where latency wasn't being reported if
a connection had UDP entirely blocked.
@kylecarbs kylecarbs enabled auto-merge (squash) September 1, 2022 03:37
@kylecarbs kylecarbs disabled auto-merge September 1, 2022 03:43
@kylecarbs kylecarbs enabled auto-merge (squash) September 1, 2022 03:51
@kylecarbs
Copy link
Member Author

This also enables keep alives. The connection was timing out every ~2mins.

@kylecarbs kylecarbs force-pushed the tailnetlatency branch 2 times, most recently from 9cd05df to ec9d4fe Compare September 1, 2022 16:10
mafredri
mafredri approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright although unfamiliar with most of it since I didn't review the original Tailscale PR 😅. Small change to ServeCoordinator could still be warranted though.

@kylecarbs kylecarbs disabled auto-merge September 1, 2022 16:26
@kylecarbs kylecarbs enabled auto-merge (squash) September 1, 2022 16:28
@kylecarbs kylecarbs merged commit 6826b97 into main Sep 1, 2022
@kylecarbs kylecarbs deleted the tailnetlatency branch September 1, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

@coadler coadler coadler approved these changes

@ammario ammario ammario approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kylecarbs @mafredri @coadler @ammario