Skip to content

feat: Add portforward to the UI #3812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 13, 2022
Merged

feat: Add portforward to the UI #3812

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a6f976e
feat: Add portforward to the UI
BrunoQuaresma Sep 1, 2022
8556bc9
Update site/src/components/PortForwardButton/PortForwardButton.tsx
BrunoQuaresma Sep 2, 2022
8e7f8bd
Merge branch 'main' of github.com:coder/coder into bq/3516
BrunoQuaresma Sep 6, 2022
ba52fed
Add CODER_ENABLE_WILDCARD_APPS env var
BrunoQuaresma Sep 6, 2022
1072f96
Merge branch 'bq/3516' of github.com:coder/coder into bq/3516
BrunoQuaresma Sep 6, 2022
f0f7156
Fix portforward link
BrunoQuaresma Sep 9, 2022
e965305
Remove t file
BrunoQuaresma Sep 9, 2022
38a0f7b
Merge branch 'main' of github.com:coder/coder into bq/3516
BrunoQuaresma Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add CODER_ENABLE_WILDCARD_APPS env var
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Sep 6, 2022
commit ba52fedfdf3a5a9d74bc49962a0560ea885d4bfd
5 changes: 4 additions & 1 deletion site/src/components/PortForwardButton/PortForwardButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ export const PortForwardButton: React.FC<React.PropsWithChildren<PortForwardButt
const styles = useStyles()
const [port, setPort] = useState("3000")
const { location } = window
const urlExample = `${location.protocol}//${port}--${workspaceName}--${agentName}--${username}.${location.host}`
const urlExample =
process.env.CODER_ENABLE_WILDCARD_APPS === "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be compiled by webpack, and isn't a dynamic environment variable at runtime. If we want to have a proper environment variable passed through, it'll have to come via the backend.

? `${location.protocol}//${port}--${workspaceName}--${agentName}--${username}.${location.host}`
: `${location.protocol}//${location.host}/@${username}/${workspaceName}/apps/${port}`

const onClose = () => {
setIsOpen(false)
Expand Down
4 changes: 4 additions & 0 deletions site/webpack.common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@ import { Configuration, EnvironmentPlugin } from "webpack"
const environmentPlugin = new EnvironmentPlugin({
INSPECT_XSTATE: "",
CODER_VERSION: "main",
CODER_ENABLE_WILDCARD_APPS: "",
})
console.info(`--- Setting INSPECT_XSTATE to '${process.env.INSPECT_XSTATE || ""}'`)
console.info(`--- Setting CODER_VERSION to '${process.env.CODER_VERSION || "main"}'`)
console.info(
`--- Setting CODER_ENABLE_WILDCARD_APPS to '${process.env.CODER_ENABLE_WILDCARD_APPS ?? ""}'`,
)
console.info(`--- Setting NODE_ENV to '${process.env.NODE_ENV || ""}'`)

/**
Expand Down