Skip to content

feat: add loaders to ssh and terminal buttons #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2022
Merged

feat: add loaders to ssh and terminal buttons #3820

merged 3 commits into from
Sep 1, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Sep 1, 2022 •
edited
Loading

Before:
image

After:
chrome_UtNuA3nSjR

@f0ssel f0ssel requested a review from a team as a code owner September 1, 2022 22:59
@f0ssel f0ssel requested review from jsjoeio and removed request for a team September 1, 2022 22:59
jsjoeio
jsjoeio approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice job!

@f0ssel f0ssel merged commit 80e9f24 into main Sep 1, 2022
@f0ssel f0ssel deleted the f0ssel/ssh-loading branch September 1, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f0ssel @jsjoeio