feat(cli): validate name length on template create #3823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test to validate that `template create` prints an error message if called with a template name exceeding the 32-char limit.
This adds a validation step to ensure the template name is less than 32 characters.
16a7da5 to
cfb2f40
Compare
coadler
reviewed
Sep 2, 2022
coadler
reviewed
Sep 2, 2022
coadler
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test to validate that
template createprints an errormessage if called with a template name exceeding the 32-char limit.
Notes to self
To run this test locally:
It doesn't look like my attempt at TDD with this is working. The test should fail so I'll need to fix that first.