Skip to content

feat: Add latency indicator to the UI #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022
Merged

feat: Add latency indicator to the UI #3846

merged 2 commits into from
Sep 2, 2022

Conversation

kylecarbs
Copy link
Member

With Tailscale, we now get a latency of all regions.

image

It looks awkward with a bunch of options. If the Tailscale DERP mapping is used, there will be ~12 regions, which would look a bit wonky with this UI. Help requested!

@kylecarbs kylecarbs requested a review from a team as a code owner September 2, 2022 17:55
@kylecarbs kylecarbs self-assigned this Sep 2, 2022
@f0ssel
Copy link
Contributor

f0ssel commented Sep 2, 2022

Maybe you could do some sort of popover on click of the latency or something

@kylecarbs
Copy link
Member Author

Not a bad idea. We can also just show the preferred region, since there will only ever be one.

With Tailscale, we now get latency of all regions.
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylecarbs kylecarbs enabled auto-merge (squash) September 2, 2022 19:46
@kylecarbs kylecarbs merged commit 2e1db6c into main Sep 2, 2022
@kylecarbs kylecarbs deleted the latency branch September 2, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants