Skip to content

revert: Makefile buff-ification (#3700) #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022
Merged

revert: Makefile buff-ification (#3700) #3848

merged 1 commit into from
Sep 2, 2022

Conversation

kylecarbs
Copy link
Member

This caused the following issues:

  • Slim binaries weren't being updated.
  • The coder.tar.ztd was misplaced.
  • There is no coder.sha1 file with proper filenames.

This should be reintroduced in a future change with those fixes.

This caused the following issues:
- Slim binaries weren't being updated.
- The coder.tar.ztd was misplaced.
- There is no coder.sha1 file with proper filenames.

This should be reintroduced in a future change with those fixes.
@kylecarbs kylecarbs requested a review from sreya September 2, 2022 19:38
@kylecarbs kylecarbs self-assigned this Sep 2, 2022
@kylecarbs kylecarbs merged commit e490bdd into main Sep 2, 2022
@kylecarbs kylecarbs deleted the revertmake branch September 2, 2022 19:46
deansheather added a commit that referenced this pull request Sep 3, 2022
deansheather added a commit that referenced this pull request Sep 6, 2022
* Revert "revert: Makefile buff-ification (#3700) (#3848)"

This reverts commit e490bdd.

* fix: fix slim targets in makefile

* fix: don't clobber slim binaries, make sure they're in the correct location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants