Skip to content

feat: add orphan support #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 6, 2022
Merged

feat: add orphan support #3849

merged 17 commits into from
Sep 6, 2022

Conversation

ammario
Copy link
Member

@ammario ammario commented Sep 2, 2022 •
edited
Loading

Resolves #3844

image

@ammario ammario requested a review from kylecarbs September 2, 2022 21:25
kylecarbs
kylecarbs requested changes Sep 2, 2022
View reviewed changes
@ammario ammario requested a review from a team as a code owner September 2, 2022 23:34
@ammario ammario requested review from BrunoQuaresma and removed request for a team September 2, 2022 23:34
@ammario
Copy link
Member Author

ammario commented Sep 2, 2022

@kylecarbs instead of adding a button to the frontend, I'm thinking we add a callout here that shows the command coder rm --orphan {workspace_name} when we're in a Failed Delete state. This way, we can add more explanation and since the command is only advertised in a failed delete state, there's a lower chance of newb misuse.

image

@ammario ammario requested a review from kylecarbs September 4, 2022 00:18
@ammario
Copy link
Member Author

ammario commented Sep 4, 2022

@kylecarbs please take a look.

BrunoQuaresma
BrunoQuaresma approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE looks good to me

kylecarbs
kylecarbs approved these changes Sep 6, 2022
View reviewed changes
ammario and others added 2 commits September 6, 2022 11:57
@ammario @kylecarbs
Update cli/delete.go
8d46045 
Co-authored-by: Kyle Carberry <kyle@coder.com>
@ammario @kylecarbs
Update cli/delete.go
e9b1edd 
Co-authored-by: Kyle Carberry <kyle@coder.com>
@ammario ammario enabled auto-merge (squash) September 6, 2022 16:58
@ammario ammario merged commit 4f0105e into main Sep 6, 2022
@ammario ammario deleted the orphan branch September 6, 2022 17:07
@bpmct bpmct mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add workspace force delete
3 participants
@ammario @BrunoQuaresma @kylecarbs