chore: parallel builds with Makefile #3854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kylecarbs
approved these changes
Sep 6, 2022
coadler
approved these changes
Sep 6, 2022
presleyp
reviewed
Sep 6, 2022
| @@ -60,6 +60,7 @@ export const createCommonWebpackConfig = (options?: { skipTypecheck: boolean }): | |||
| // REMARK: It's important to use [contenthash] here to invalidate caches. | |||
| filename: "bundle.[contenthash].js", | |||
| path: path.resolve(__dirname, "out"), | |||
| clean: false, | |||
There was a problem hiding this comment.
Just curious to understand the clean strategy here and in prod better! Might be smart for us to leave a comment about it too.
There was a problem hiding this comment.
I'll add a comment here in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues laid out in #3848
The real diff can be viewed using by clicking on the specific commits below instead of viewing the entire PR diff.