Skip to content

feat: Add profile pictures for OAuth users #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2022
Merged

feat: Add profile pictures for OAuth users #3855

merged 1 commit into from
Sep 4, 2022

Conversation

kylecarbs
Copy link
Member

This supports GitHub and OIDC login for profile pictures!

It doesn't support uploading external images, but that felt overkill for built-in auth. Each time a user authenticates, the profile picture URL will update.

@kylecarbs kylecarbs requested a review from sreya September 3, 2022 16:16
@kylecarbs kylecarbs self-assigned this Sep 3, 2022
@kylecarbs kylecarbs requested a review from a team as a code owner September 3, 2022 16:16
@kylecarbs kylecarbs requested review from Kira-Pilot and removed request for a team September 3, 2022 16:16
@kylecarbs kylecarbs changed the title feat: Add profile pictures to OAuth users feat: Add profile pictures for OAuth users Sep 3, 2022
@kylecarbs kylecarbs force-pushed the profilepic branch 5 times, most recently from 38323e4 to 95475be Compare September 3, 2022 17:19
This supports GitHub and OIDC login for profile pictures!
@kylecarbs kylecarbs merged commit 05e2806 into main Sep 4, 2022
@kylecarbs kylecarbs deleted the profilepic branch September 4, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants