Skip to content

chore: Reduce test times #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2022
Merged

chore: Reduce test times #3856

merged 3 commits into from
Sep 4, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Sep 3, 2022 •
edited
Loading

Discovered with: go test -json -short ./... | gotestsum tool slowest

  • Testing the timeout for testutil.Eventually is not required since other tests that consume it would error.
  • TestPaginatedTemplateVersions doesn't need fully built templates!
  • Renames IncludeProvisionerD to IncludeProvisionerDaemon. It just looks a bit nicer IMO
  • Increased test provisioner daemon refresh intervals. They were refreshing really quickly, which actually slowed things down.

@kylecarbs kylecarbs requested a review from coadler September 3, 2022 16:38
@kylecarbs kylecarbs marked this pull request as ready for review September 3, 2022 17:06
@kylecarbs kylecarbs merged commit 67c4605 into main Sep 4, 2022
@kylecarbs kylecarbs deleted the improvetesttimes branch September 4, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler