feat: use active users instead of total users in Template views #3900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a67043e to
464c344
Compare
464c344 to
c5787be
Compare
code-asher
reviewed
Sep 6, 2022
There was a problem hiding this comment.
I think the wrong issue is linked in the PR description. Looks like it should be #3815.
Is there something I need to do to enable metrics? Or maybe I need to wait longer? (35 mins since creating the template so far.) My template only shows Looks like it just took some time; it is showing now! 🎉- developers. 😭
code-asher
reviewed
Sep 9, 2022
code-asher
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3815
This PR adds functionality to the metricscache, coderd, and frontend to use Active Users instead of Total Users in template presentation. Active Users is a better indicator of template importance.