feat: Add table support and syntax highlights for markdowns #3910
Conversation
|
Closes #3896 |
| // Adding node so the ...props don't have it | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
❓ help me understand this (sorry if it's obvious 😂) we destructure node but don't use it, how come?
does prefixing with _ fix the ESLint warning?
There was a problem hiding this comment.
we destructure node but don't use it, how come?
Because we are getting the ...props and we don't want props having node.
does prefixing with _ fix the ESLint warning?
Yes, but if I use _node it will return _node not found because _node is not an attribute. I could do node: _node but I think it is more confusing than letting it as it is and adding an ignoring comment.
There was a problem hiding this comment.
Ahhh okay, that makes sense! Thanks for explaining!
| PreTag="div" | ||
| {...props} | ||
| > | ||
| {String(children).replace(/\n$/, "")} |
There was a problem hiding this comment.
How come we have to do this .replace? Is it to remove line breaks or something?
There was a problem hiding this comment.
Yes, it is so the highlight component can struct it properly. I got this from the react-markdown docs https://github.com/remarkjs/react-markdown#use-custom-components-syntax-highlight
|
wohoo! I'm adding tables back to my templates now |
These preview images are from a storybook so the background and width can look "ugly".