Skip to content

chore: Update PR template to mention checking for docs #3913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

kylecarbs
Copy link
Member

This arose from a conversation Presley and I had about developers
maintaining docs, and that this little reminder could be useful!

This arose from a conversation Presley and I had about developers
maintaining docs, and that this little reminder could be useful!
@kylecarbs kylecarbs requested a review from presleyp September 6, 2022 20:08
@kylecarbs kylecarbs self-assigned this Sep 6, 2022
@kylecarbs kylecarbs marked this pull request as ready for review September 6, 2022 20:08
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsjoeio I think I remember you writing the old comment - anything you think we still need to mention?

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 6, 2022

@jsjoeio I think I remember you writing the old comment - anything you think we still need to mention?

I don't think so - thank you for flagging me! Seems like a great idea.

@kylecarbs kylecarbs merged commit 8596023 into main Sep 8, 2022
@kylecarbs kylecarbs deleted the prtemplate branch September 8, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants