Skip to content

Add periods to end of license warning text. #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2022
Merged

Add periods to end of license warning text. #3933

merged 2 commits into from
Sep 7, 2022

Conversation

spikecurtis
Copy link
Contributor

Full sentences with periods will make things look better on front end.

@spikecurtis
Add periods to end of license warning text.
9a05a11 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis requested a review from presleyp September 7, 2022 16:53
presleyp
presleyp approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spikecurtis
Fix tests
d46577c 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis enabled auto-merge (squash) September 7, 2022 17:20
@spikecurtis spikecurtis merged commit ac279b3 into main Sep 7, 2022
@spikecurtis spikecurtis deleted the spike/warnings_with_periods branch September 7, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikecurtis @presleyp @kylecarbs