feat: Use Tailscale networking by default #4003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removal of WebRTC code will happen in another PR, but it felt dangerious to default and remove in a single commit. Ideally, we can release this version and collect final thoughts and feedback before a full commitment.
9ee7e9b to
c2bc664
Compare
949d353 to
be6ab1e
Compare
Tailscale doesn't support this, and adding support for it shouldn't block our rollout. Customers can always forward over SSH.
deansheather
requested changes
Sep 13, 2022
Co-authored-by: Dean Sheather <dean@deansheather.com>
|
@deansheather it seems like it'd be quite a lot of work to implement, and the scope isn't quite clear. For now, I recommend we tell users to forwards UNIX sockets over SSH (even though the throughput isn't the best). |
deansheather
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of WebRTC code will happen in another PR, but it felt dangerous to default and remove in a single commit.
Ideally, we can release this version and collect final thoughts and feedback before fully committing.