Skip to content

feat: Show custom resource icons #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 13, 2022
Merged

feat: Show custom resource icons #4020

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e61d3e9
Update examples templateversion
BrunoQuaresma Sep 12, 2022
c764b21
Updaate backend to accept icon
BrunoQuaresma Sep 12, 2022
f9883c7
Fix entities
BrunoQuaresma Sep 12, 2022
1411f05
Fix test
BrunoQuaresma Sep 12, 2022
fc97c5a
Remove test
BrunoQuaresma Sep 12, 2022
a1ba920
Fix proto and tests
BrunoQuaresma Sep 12, 2022
d608290
Update version
BrunoQuaresma Sep 12, 2022
72bb2f0
Update tfplans
BrunoQuaresma Sep 12, 2022
e8b2d9d
Generate provisioner data
BrunoQuaresma Sep 12, 2022
87d7de7
Update FE to use custom icons
BrunoQuaresma Sep 13, 2022
29f66fb
Merge branch 'main' of github.com:coder/coder into bq/3487
BrunoQuaresma Sep 13, 2022
47bb391
Fix migrations
BrunoQuaresma Sep 13, 2022
e5792fa
Fix eslint error
BrunoQuaresma Sep 13, 2022
086f265
Fix template resources table
BrunoQuaresma Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Sep 12, 2022
commit fc97c5a0f80af515d99fbdffda73a445af9bb97f
3 changes: 0 additions & 3 deletions coderd/workspaceresources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ func TestWorkspaceResource(t *testing.T) {
Resources: []*proto.Resource{{
Name: "beta",
Type: "example",
Icon: "/icon/server.svg",
Agents: []*proto.Agent{{
Id: "something",
Name: "b",
Expand Down Expand Up @@ -64,8 +63,6 @@ func TestWorkspaceResource(t *testing.T) {
// Ensure agents are sorted alphabetically!
require.Equal(t, "a", resource.Agents[0].Name)
require.Equal(t, "b", resource.Agents[1].Name)
// Ensure Icon is present
require.Equal(t, "/icon/server.svg", resources[1].Icon)
})

t.Run("Apps", func(t *testing.T) {
Expand Down