Skip to content

feat: display specific errors if templates page fails #4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 13, 2022
Merged

feat: display specific errors if templates page fails #4023

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
36cb15e
Surface templates page errors
presleyp Sep 9, 2022
e1dbcd9
Format
presleyp Sep 9, 2022
7c788ab
Separate error messages
presleyp Sep 12, 2022
380d6ad
Fix story
presleyp Sep 12, 2022
302b853
Format
presleyp Sep 12, 2022
2d24806
Merge branch 'main' into presleyp/template-errors
presleyp Sep 12, 2022
883ddc1
Format
presleyp Sep 12, 2022
d01a45d
Fix imports
presleyp Sep 12, 2022
e31e658
Remove unnecessary check
presleyp Sep 12, 2022
f845af1
Format
presleyp Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary check
  • Loading branch information
@presleyp
presleyp committed Sep 12, 2022
commit e31e658d3d98513b9aafccec9dace1d3fc56a801
12 changes: 5 additions & 7 deletions site/src/pages/TemplatesPage/TemplatesPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,11 @@ export const TemplatesPageView: FC<React.PropsWithChildren<TemplatesPageViewProp
title={template.name}
subtitle={template.description}
highlightTitle
avatar={
hasIcon ? (
<div className={styles.templateIconWrapper}>
<img alt="" src={template.icon} />
</div>
) : undefined
}
avatar={hasIcon && (
<div className={styles.templateIconWrapper}>
<img alt="" src={template.icon} />
</div>
)}
/>
</TableCellLink>

Expand Down