Skip to content

feat: Allow deleting users #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 12, 2022
Merged

feat: Allow deleting users #4028

merged 5 commits into from
Sep 12, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Sep 12, 2022 •
edited
Loading

Fixes #2731.

image
image

@kylecarbs kylecarbs force-pushed the userdelete branch 2 times, most recently from 914a546 to ad9ee3d Compare September 12, 2022 21:20
@kylecarbs kylecarbs marked this pull request as ready for review September 12, 2022 21:21
@kylecarbs kylecarbs requested a review from a team as a code owner September 12, 2022 21:21
@kylecarbs kylecarbs requested review from presleyp and removed request for a team September 12, 2022 21:21
@kylecarbs kylecarbs self-assigned this Sep 12, 2022
BrunoQuaresma
BrunoQuaresma approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylecarbs kylecarbs enabled auto-merge (squash) September 12, 2022 23:14
@kylecarbs kylecarbs merged commit 850a830 into main Sep 12, 2022
@kylecarbs kylecarbs deleted the userdelete branch September 12, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@presleyp presleyp Awaiting requested review from presleyp presleyp was automatically assigned from coder/ts

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to delete user accounts
2 participants
@kylecarbs @BrunoQuaresma