Revert "feat: Add portforward to the UI (#3812)" #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kylecarbs merged 1 commit into main from revertport

Sep 13, 2022

Member

kylecarbs commented Sep 13, 2022

This reverts commit 0552c36 for the following reasons:

It doesn't make sense to port-forward to a sub-path. Directing a user to /@kyle/dev/apps/3000 will not work if the user has a single-page application that doesn't support the base HTML tag.
The environment variable to enable this doesn't work at runtime. Environment variables in frontend code are used at compile-time, not runtime. This variable needs to be piped through a meta tag to our static site serving code to be used in the FE.


          Revert "feat: Add portforward to the UI (#3812)"

63ce2ef

This reverts commit 0552c36.

kylecarbs requested a review from a team as a code owner

September 13, 2022 21:24

kylecarbs requested review from presleyp and removed request for a team

September 13, 2022 21:24

presleyp approved these changes

View reviewed changes

kylecarbs merged commit 4f0417c into main

kylecarbs deleted the revertport branch

September 13, 2022 22:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet