Skip to content

Fix kubectl get pods command in k8s install docs #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2022
Merged

Fix kubectl get pods command in k8s install docs #4053

merged 2 commits into from
Sep 19, 2022

Conversation

jamesottaway
Copy link
Contributor

@jamesottaway jamesottaway commented Sep 14, 2022 •
edited
Loading

It was missing the namespace used in the rest of the tutorial.

Also fixes #4054.

@jamesottaway jamesottaway mentioned this pull request Sep 14, 2022
Closed
@ghuntley ghuntley enabled auto-merge (squash) September 16, 2022 00:03
@ghuntley
Copy link
Contributor

Thanks @jamesottaway. I'm going to be heading up to Brisbane shortly if you ever want to catch up for beers and riff re: coder.

@bpmct
Copy link
Member

bpmct commented Sep 16, 2022

Thanks for the fixes!

@jamesottaway @bpmct
Fix kubectl get pods command
e616477 
It was missing the namespace used in the rest of the tutorial.
@jamesottaway @bpmct
Fix the coder-db-url secret's hostname
0710543
@ghuntley ghuntley merged commit 9196b39 into coder:main Sep 19, 2022
@jamesottaway jamesottaway deleted the patch-2 branch September 20, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@ericpaulsen ericpaulsen ericpaulsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes Install docs include wrong PG hostname
5 participants
@jamesottaway @ghuntley @bpmct @kylecarbs @ericpaulsen