Skip to content

refactor: Remove users redirect to active filter #4056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 15, 2022
Merged

refactor: Remove users redirect to active filter #4056

merged 7 commits into from
Sep 15, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Sep 14, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner September 14, 2022 16:44
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team September 14, 2022 16:44
code-asher
code-asher approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and runs perfectly 👍

@BrunoQuaresma BrunoQuaresma merged commit 40c0fc2 into main Sep 15, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-users-page branch September 15, 2022 13:05
@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 15, 2022

question: would this refactor cause the e2e test to break? I'm removing the filter here 🤞🏼 609e7d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrunoQuaresma @jsjoeio @code-asher @kylecarbs