feat: provisionerd tracing, add public trace ingestion #4070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
375d861 to
1025ce1
Compare
1025ce1 to
1b09927
Compare
mafredri
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Looks really good, will be great to have some more insight into the provisioner jobs as well!
Food for thought: Since we're sending traces now by default to our endpoint, we'll have to be extra careful not to log/tag anything sensitive or information that may identify a person.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round two of adding tracing to provisionerd, previously provisionerd got rewritten while my tracing stuff was in progress (#2675), so I redid it with the new API.
This also adds public trace ingestion. This will allow us to instrument customer deployments and monitor the performance of Coder in the wild.