Skip to content

fix: Only update workspace LastUsed when the connection payload has changed #4115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix: Only update workspace LastUsed when the connection payload has changed #4115

merged 1 commit into from
Sep 19, 2022

Conversation

kylecarbs
Copy link
Member

This was causing every workspace to update last used to time.Now() when coderd was restarted!

@kylecarbs kylecarbs requested a review from ammario September 19, 2022 17:53
@kylecarbs kylecarbs self-assigned this Sep 19, 2022
@kylecarbs
fix: Only update workspace LastUsed when the connection payload has c…
1f97d65 
…hanged

This was causing every workspace to update last used to time.Now() when
coderd was restarted!
@kylecarbs kylecarbs mentioned this pull request Sep 19, 2022
Closed
@kylecarbs kylecarbs merged commit 72d6731 into main Sep 19, 2022
@kylecarbs kylecarbs deleted the lastused branch September 19, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammario ammario ammario approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @ammario