Skip to content

feat: use sse for workspace page #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 21, 2022
Merged

feat: use sse for workspace page #4122

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a813f7f
added error handling
Kira-Pilot Sep 19, 2022
24fdd15
workspace machine cleanup
Kira-Pilot Sep 19, 2022
a3bc55e
renaming callback
Kira-Pilot Sep 20, 2022
f24d70b
general cleanup
Kira-Pilot Sep 20, 2022
80c5fac
fixed tests
Kira-Pilot Sep 21, 2022
65a1dc4
Merge remote-tracking branch 'origin/main' into workspace-sse/kira-pilot
Kira-Pilot Sep 21, 2022
1cfe862
PR comments
Kira-Pilot Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
renaming callback
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed Sep 20, 2022
commit a3bc55e097c7297d16848693e4070c95c577d080
12 changes: 6 additions & 6 deletions site/src/xServices/workspace/workspaceXService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,28 +624,28 @@ export const workspaceMachine = createMachine(
throw Error("Cannot cancel workspace without build id")
}
},
listenForEvents: (context) => (callback) => {
listenForEvents: (context) => (send) => {
if (!context.sse) {
callback({ type: "SSE_ERROR", error: "error initializing sse" })
send({ type: "SSE_ERROR", error: "error initializing sse" })
return
}

context.sse.addEventListener("data", (event) => {
// update our data objects (workspace, resources) with each SSE that comes back from the server
callback({ type: "UPDATE_EVENT", data: JSON.parse(event.data) })
send({ type: "UPDATE_EVENT", data: JSON.parse(event.data) })
// refresh our timeline
callback({ type: "CHECK_REFRESH_TIMELINE", data: JSON.parse(event.data) })
send({ type: "CHECK_REFRESH_TIMELINE", data: JSON.parse(event.data) })
})

// handle any error events returned by our sse
context.sse.addEventListener("error", (event) => {
callback({ type: "SSE_ERROR", error: event })
send({ type: "SSE_ERROR", error: event })
})

// handle any sse implementation exceptions
context.sse.onerror = () => {
context.sse && context.sse.close();
callback({ type: "SSE_ERROR", error: "sse error" })
send({ type: "SSE_ERROR", error: "sse error" })
}

},
Expand Down