Skip to content

feat: add SCIM provisioning via Okta #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 20, 2022
Merged

feat: add SCIM provisioning via Okta #4132

merged 8 commits into from
Sep 20, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Sep 20, 2022

No description provided.

@coadler coadler self-assigned this Sep 20, 2022
kylecarbs
kylecarbs reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't delete users, right? I wonder if people will want/expect that, but it gets a bit tricky because of workspaces...

enterprise/coderd/coderd.go
if len(options.ScimAPIKey) != 0 {
api.AGPL.RootHandler.Route("/scim/v2", func(r chi.Router) {
r.Use(api.scimEnabledMW)
r.Post("/Users", api.scimPostUser)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital U? :o

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is the SCIM spec :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

craaaazy

@coadler
Copy link
Contributor Author

coadler commented Sep 20, 2022

This doesn't delete users, right? I wonder if people will want/expect that, but it gets a bit tricky because of workspaces...

Yeah, this is probably fine for now too. People mostly care about deprovisioning access. Deprovisioning resources can definitely be a follow up.

@coadler coadler mentioned this pull request Sep 20, 2022
Closed
@coadler coadler requested a review from kylecarbs September 20, 2022 17:08
kylecarbs
kylecarbs reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add docs in this PR too.

https://coder.com/docs/coder-oss/latest/admin/auth you can add a section for SCIM. I'm sure @bpmct would help!

bpmct
bpmct reviewed Sep 20, 2022
View reviewed changes
coadler and others added 2 commits September 20, 2022 13:24
@bpmct
Copy link
Member

bpmct commented Sep 20, 2022

closes #3501

@coadler coadler linked an issue Sep 20, 2022 that may be closed by this pull request
Automated user provisioning via SCIM #3501
Closed
@coadler coadler requested a review from kylecarbs September 20, 2022 19:53
@coadler coadler merged commit 5e2efb6 into main Sep 20, 2022
@coadler coadler deleted the colin/entfactor-scim2 branch September 20, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpmct bpmct bpmct left review comments

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated user provisioning via SCIM
3 participants
@coadler @bpmct @kylecarbs