Skip to content

chore: Add linter rule to prevent breaking of sse #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Sep 21, 2022

This linter rule prevents us from creating a response writer wrapper without fully implementing all the required interfaces.

  • http.Flusher is required for Server side events
  • http.Hijacker is required for websockets.

@Emyrk Emyrk requested a review from f0ssel September 21, 2022 12:10
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful

Copy link
Contributor

@coadler coadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

@Emyrk Emyrk merged commit 27c8345 into main Sep 27, 2022
@Emyrk Emyrk deleted the stevenmasley/protect-sse branch September 27, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants