chore: Use Vite instead of Webpack for development #4156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Sep 23, 2022
jsjoeio
reviewed
Sep 23, 2022
| @@ -0,0 +1,37 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
❓ Why do we have to add this? (Or is this a file move? hard to tell)
There was a problem hiding this comment.
Vite requires the HTML file to be in the root.
| @@ -10,6 +10,7 @@ | |||
| "check:all": "yarn format:check && yarn lint && yarn test", | |||
| "chromatic": "chromatic", | |||
| "dev": "webpack-dev-server --config=webpack.dev.ts", | |||
| "dev:vite": "vite", | |||
There was a problem hiding this comment.
I like that you're leaving webpack in and encouraging folks to try vite. Seems like the right move and then when we're confident Vite works, we can remove webpack 👍🏼
|
Probably user error, but how do you log in when you use a different host? I tried with GitHub but get this error:
I did get it to work by manually editing The first load of pages seems a bit slower (maybe the lazy load?) but other than that seems to work great! HMR is so fast with Vite! Screen.Recording.2022-09-23.at.10.41.52.AM.mov |
jsjoeio
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intentions:
How to use:
I would appreciate it if people could test it and help me to catch any bugs before replacing webpack entirely.