chore: Change usage of ChooseOne (no final condition) #4158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
approved these changes
Sep 23, 2022
| return chosen ?? childArray[childArray.length - 1] | ||
| const conditionedOptions = childArray.slice(0, childArray.length - 1) | ||
| const defaultCase = childArray[childArray.length - 1] | ||
| if (defaultCase.props.condition !== undefined) { |
There was a problem hiding this comment.
idk if this is worth consideration but if given an empty array defaultCase would be undefined I think?
There was a problem hiding this comment.
Thanks! How does this look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our conversation in Frontend Variety, I made the
conditionprop optional inCondcomponent.ChooseOnewill throw an error if you use one on your default case, or don't use one in a non-final case.