Skip to content

Add AWS and Azure quickstarts #4176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 3, 2022
Merged

Add AWS and Azure quickstarts #4176

merged 9 commits into from
Oct 3, 2022

Conversation

endingwithali
Copy link
Contributor

First two quick starts for moving quick with azure and AWS are ready to publish

bpmct
bpmct requested changes Sep 23, 2022
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited to see these coming together. I noticed some minor typos as well as Markdown syntax errors. For the content that is repeated for AWS and Azure, I only left a comment on AWS.

ammario
ammario requested changes Sep 24, 2022
View reviewed changes
@ammario ammario changed the title Merge in AWS and Azure quick starts Add AWS and Azure quick starts Sep 24, 2022
@ammario ammario changed the title Add AWS and Azure quick starts Add AWS and Azure quickstarts Sep 24, 2022
@ammario
Copy link
Member

ammario commented Sep 24, 2022

@endingwithali I renamed the PR to Add AWS and Azure quickstarts instead of Merge AWS and Azure quickstarts to be consistent with our other PRs and commits. Beginning a commit with Merge, Rebase or some git operation is a bad practice since that information is already implied in the Git object.

@ammario
Copy link
Member

ammario commented Sep 24, 2022

Also, please ensure that this lays out correctly in coder.com before merging.

ammario
ammario requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't thoroughly review the Azure Quickstart yet

bpmct
bpmct reviewed Sep 26, 2022
View reviewed changes
@endingwithali
Copy link
Contributor Author

Also, please ensure that this lays out correctly in coder.com before merging.

checked by building and running docs locally

bpmct
bpmct approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another review and it LGTM. I found some tiny things and another point of feedback is you mention both "system level service" and "system service." I prefer the latter but mostly would prefer it to be consistent.

ammario
ammario requested changes Sep 27, 2022
View reviewed changes
@endingwithali endingwithali requested review from ammario and bpmct October 3, 2022 16:27
ammario
ammario reviewed Oct 3, 2022
View reviewed changes
@endingwithali endingwithali requested a review from ammario October 3, 2022 20:31
ammario
ammario requested changes Oct 3, 2022
View reviewed changes
@endingwithali endingwithali requested a review from ammario October 3, 2022 20:54
@ammario
Copy link
Member

ammario commented Oct 3, 2022

🕺🏽🕺🏽🕺🏽🕺🏽🕺🏽

@endingwithali endingwithali added the docs Area: coder.com/docs label Oct 3, 2022
@endingwithali endingwithali merged commit 1d88b9c into main Oct 3, 2022
@endingwithali endingwithali deleted the endingwithali/quickstarts-azure-aws branch October 3, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammario ammario ammario approved these changes

@bpmct bpmct bpmct approved these changes

Assignees
No one assigned
Labels
docs Area: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endingwithali @ammario @bpmct