Skip to content

chore: ignore traces from (*API).workspaceAgentCoordinate after accept #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

chore: ignore traces from (*API).workspaceAgentCoordinate after accept #4178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions coderd/tracing/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
package tracing

import (
"context"
"runtime"
"strings"

"go.opentelemetry.io/otel/trace"
)

var NoopSpan trace.Span

func init() {
tracer := trace.NewNoopTracerProvider().Tracer("")
_, NoopSpan = tracer.Start(context.Background(), "")
}

const TracerName = "coderd"

func FuncName() string {
Expand Down
5 changes: 4 additions & 1 deletion coderd/workspaceagents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,11 @@ func (api *API) workspaceAgentCoordinate(rw http.ResponseWriter, r *http.Request
return
}

// end span so we don't get long lived trace data
// End span so we don't get long lived trace data.
tracing.EndHTTPSpan(r, http.StatusOK, trace.SpanFromContext(ctx))
// Ignore all trace spans after this.
ctx = trace.ContextWithSpan(ctx, tracing.NoopSpan)

api.Logger.Info(ctx, "accepting agent", slog.F("resource", resource), slog.F("agent", workspaceAgent))

defer conn.Close(websocket.StatusNormalClosure, "")
Expand Down