Skip to content

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Sep 23, 2022

chrome_CMVLXav8IZ

Rebased and is now integrated with the "create workspace for user" selector!

@f0ssel f0ssel marked this pull request as ready for review September 29, 2022 17:39
@f0ssel f0ssel requested a review from a team as a code owner September 29, 2022 17:39
@f0ssel f0ssel requested review from jsjoeio and removed request for a team September 29, 2022 17:39
@f0ssel
Copy link
Contributor Author

f0ssel commented Sep 29, 2022

@coder/frontend this is ready for FE review, still need to work on tests for the backend. let me know if anything is not up to snuff.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a FE perspective! ✅

fyi: I didn't check the BE code too closely since I'm less familiar

@f0ssel f0ssel requested review from kylecarbs and coadler September 29, 2022 18:49
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix up that query then feel free to merge!

@f0ssel f0ssel merged commit 69c73b2 into main Sep 30, 2022
@f0ssel f0ssel deleted the f0ssel/quotas branch September 30, 2022 18:01
@f0ssel f0ssel mentioned this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants