feat: Add templates to create working release #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 63.19% 62.13% -1.07%
==========================================
Files 79 191 +112
Lines 864 10856 +9992
Branches 85 85
==========================================
+ Hits 546 6745 +6199
- Misses 302 3375 +3073
- Partials 16 736 +720
Continue to review full report at Codecov.
|
Comment on lines
+31
to
+34
| *.tfstate | ||
| *.tfplan | ||
| *.lock.hcl | ||
| .terraform/ |
cli/cliui/cliui.go
Outdated
Comment on lines
48
to
49
|
|
||
| // coder login |
There was a problem hiding this comment.
I wasn't sure what this trailing comment is for, maybe just leftover?
cli/cliui/list.go
Outdated
|
|
||
| switch msg := msg.(type) { | ||
| case tea.WindowSizeMsg: | ||
| // topGap, rightGap, bottomGap, leftGap := appStyle.GetPadding() |
There was a problem hiding this comment.
Maybe not needed anymore?
cli/cliui/list.go
Outdated
| import ( | ||
| "github.com/charmbracelet/bubbles/key" | ||
| "github.com/charmbracelet/bubbles/list" | ||
| tea "github.com/charmbracelet/bubbletea" |
There was a problem hiding this comment.
This looks like a neat library 👍
cli/ssh.go
Outdated
|
|
||
| func workspaceSSH() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "ssh", |
Comment on lines
+36
to
+44
| // probe, err := cloud.New() | ||
| // if err != nil { | ||
| // return xerrors.Errorf("probe cloud: %w", err) | ||
| // } | ||
| // if !probe.Detected { | ||
| // return xerrors.Errorf("no valid authentication method found; set \"CODER_TOKEN\"") | ||
| // } | ||
| // switch { | ||
| // case probe.GCP(): |
There was a problem hiding this comment.
Might be able to remove this?
cmd/cliui/main.go
Outdated
| Description: "Something...", | ||
| }, { | ||
| Title: "Wow, here's another!", | ||
| Description: "Another exciting description!", |
There was a problem hiding this comment.
I like these placeholder descriptions 😆
I guess these are just for testing out the API?
Comment on lines
+40
to
+41
| // Taken from: | ||
| // https://github.com/cloudflare/cloudflared/blob/22cd8ceb8cf279afc1c412ae7f98308ffcfdd298/cmd/cloudflared/tunnel/quick_tunnel.go#L38 |
There was a problem hiding this comment.
Thanks for this context
| @@ -19,15 +18,15 @@ func TestFirstUser(t *testing.T) { | |||
| t.Run("BadRequest", func(t *testing.T) { | |||
| t.Parallel() | |||
| client := coderdtest.New(t, nil) | |||
| _, err := client.CreateFirstUser(context.Background(), coderd.CreateFirstUserRequest{}) | |||
| _, err := client.CreateFirstUser(context.Background(), codersdk.CreateFirstUserRequest{}) | |||
There was a problem hiding this comment.
I realized one thing that would make this more incremental & easier to review is to have the coderd -> codersdk name change as a separate PR (but I know its hard to do when a lot is changing)
template/gcp-linux/gcp-linux.json
Outdated
| { | ||
| "ID": "gcp-linux", | ||
| "Name": "Develop in Linux on Google Cloud", | ||
| "Description": "Get started with Linux development on Google Cloud.", |
template/template.go
Outdated
Comment on lines
18
to
20
| //go:embed */*.json | ||
| //go:embed */*.tf | ||
| files embed.FS |
There was a problem hiding this comment.
I like this strategy of embedding some pre-set templates to start!
bryphe-coder
approved these changes
Mar 12, 2022
|
Was looking at the latest failure to see if it was one captured by some others we're seeing recently:
But this looks like a new one, related to the https://github.com/coder/coder/runs/5545694820?check_suite_focus=true#step:7:109 |
bryphe-coder
added a commit
that referenced
this pull request
Mar 16, 2022
This adds a couple of missing pieces to the docs: - More info about `./develop.sh` - Steps to run the built coder binary manually - Starting the server - Logging in - Creating a project I attempted to keep them relatively agnostic so they wouldn't be out of date immediately when #422 is merged
greyscaled
approved these changes
Mar 16, 2022
| @@ -17,7 +17,7 @@ const config: PlaywrightTestConfig = { | |||
| // https://playwright.dev/docs/test-advanced#launching-a-development-web-server-during-the-tests | |||
| webServer: { | |||
| // Run the coder daemon directly. | |||
| command: `go run ${path.join(__dirname, "../../cmd/coder/main.go")} daemon`, | |||
| command: `go run -tags embed ${path.join(__dirname, "../../cmd/coder/main.go")} start`, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to run
coder start --devto start an instance, expose it to the internet, and use a premade template for ease.