Skip to content

fix: update workspace button should properly update the workspace #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2022
Merged

fix: update workspace button should properly update the workspace #4228

merged 2 commits into from
Sep 27, 2022

Conversation

Kira-Pilot
Copy link
Member

Resolves #4098

We didn't have the latest template on our machine context so we weren't sending down the correct template.active_version_id when posting a new build.

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner September 27, 2022 18:59
@Kira-Pilot Kira-Pilot requested review from greyscaled, bpmct and BrunoQuaresma and removed request for a team and greyscaled September 27, 2022 18:59
BrunoQuaresma
BrunoQuaresma approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor question, during the refreshTemplate state, does the UI show a loader? So the user knows the workspace is updating?

@BrunoQuaresma
Copy link
Collaborator

Also, something that could be done is to encapsulate those states so it is easier to know they are related like:

updatingWorkspace: {
    initial: "refreshingTemplate",
    states: {
        refreshingTemplate: {...},
        startingWithLatest: {...},
    }
}

kylecarbs
kylecarbs approved these changes Sep 27, 2022
View reviewed changes
site/src/xServices/workspace/workspaceXService.ts Outdated
@@ -271,6 +271,20 @@ export const workspaceMachine = createMachine(
},
},
},
refreshTemplate: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be refreshTemplateAndStart instead? It could be a bit misleading since it doesn't just refresh.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylecarbs It does just refresh actually, but I agree - it's part of a larger plan and the naming doesn't capture that. Would it feel better if I applied Bruno's grouping suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yup I think that'd make sense!

@Kira-Pilot
Copy link
Member Author

LGTM. Just a minor question, during the refreshTemplate state, does the UI show a loader? So the user knows the workspace is updating?

It does now!

@Kira-Pilot Kira-Pilot merged commit 65ff604 into main Sep 27, 2022
@Kira-Pilot Kira-Pilot deleted the fix-update-button/kira-pilot branch September 27, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace with Outdated status does not update the first time you click update
3 participants
@Kira-Pilot @BrunoQuaresma @kylecarbs