chore: Use Vite as main dev runner for FE #4230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Sep 27, 2022
| @@ -136,8 +134,7 @@ | |||
| "typescript": "4.8.2", | |||
| "webpack": "5.74.0", | |||
There was a problem hiding this comment.
Should we use Vite for production too?
There was a problem hiding this comment.
Yes, but I have to run some experiments to check the build and build size.
kylecarbs
approved these changes
Sep 27, 2022
jsjoeio
approved these changes
Sep 27, 2022
Comment on lines
135
to
136
| "webpack": "5.74.0", | ||
| "webpack-bundle-analyzer": "4.6.1", |
There was a problem hiding this comment.
It is kinda used to analyze the build, but I don't think we use this anywhere I will remove this after just for caution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.