Skip to content

chore: Use Vite as main dev runner for FE #4230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2022
Merged

chore: Use Vite as main dev runner for FE #4230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6b04ab
chore: Use Vite as main dev runner
BrunoQuaresma Sep 27, 2022
7e0da89
Update deps
BrunoQuaresma Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/develop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ CODER_DEV_SHIM="${PROJECT_ROOT}/scripts/coder-dev.sh"
fi

# Start the frontend once we have a template up and running
CODER_HOST=http://127.0.0.1:3000 INSPECT_XSTATE=false yarn --cwd=./site dev:vite || kill -INT -$$ &
CODER_HOST=http://127.0.0.1:3000 yarn --cwd=./site dev || kill -INT -$$ &

log
log "===================================================================="
Expand Down
7 changes: 2 additions & 5 deletions site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"build:analyze": "NODE_ENV=production webpack --profile --progress --json --config=webpack.prod.ts > out/stats.json && webpack-bundle-analyzer out/stats.json out",
"check:all": "yarn format:check && yarn lint && yarn test",
"chromatic": "chromatic",
"dev": "webpack-dev-server --config=webpack.dev.ts",
"dev:vite": "vite",
"dev": "vite",
"format:check": "prettier --check '**/*.{css,html,js,json,jsx,md,ts,tsx,yaml,yml}'",
"format:types": "prettier --write 'src/api/typesGenerated.ts'",
"format:write": "prettier --write '**/*.{css,html,js,json,jsx,md,ts,tsx,yaml,yml}'",
Expand Down Expand Up @@ -78,7 +77,6 @@
},
"devDependencies": {
"@playwright/test": "1.25.1",
"@pmmmwh/react-refresh-webpack-plugin": "0.5.7",
"@storybook/addon-actions": "6.5.9",
"@storybook/addon-essentials": "6.5.12",
"@storybook/addon-links": "6.5.9",
Expand Down Expand Up @@ -136,8 +134,7 @@
"typescript": "4.8.2",
"webpack": "5.74.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Vite for production too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I have to run some experiments to check the build and build size.

"webpack-bundle-analyzer": "4.6.1",
Comment on lines 135 to 136
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is kinda used to analyze the build, but I don't think we use this anywhere I will remove this after just for caution.

"webpack-cli": "4.10.0",
"webpack-dev-server": "4.10.1"
"webpack-cli": "4.10.0"
},
"browserslist": [
"chrome 66",
Expand Down
120 changes: 0 additions & 120 deletions site/webpack.dev.ts
View file
Open in desktop

This file was deleted.

Loading