Skip to content

feat: add template RBAC/groups #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 161 commits into from
Oct 10, 2022
Merged

feat: add template RBAC/groups #4235

merged 161 commits into from
Oct 10, 2022

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Sep 28, 2022 •
edited
Loading

fixes #3102

Emyrk and others added 30 commits September 13, 2022 12:32
@Emyrk
feat: Add ACL list support to rego objects
5a47132
@Emyrk
Add unit tests
03f69bf
@Emyrk
Rename ACL list
91a358d
@Emyrk
Flip rego json to key by user id
8f837b7
@sreya
feat: add template ACL
8378c9b
@sreya
add down migration
54a0d13
@sreya
remove unused file
72ea751
@sreya
undo insert templates query change
d533a16
@sreya
add patch endpoint tests
f56fcf9
@Emyrk
Unit test use shadowed copied value
f162694
@Emyrk
Allow wildcards for ACL list
ea25c08
@sreya
fix authorize bug
5a081eb
@Emyrk
feat: Allow filter to accept objects of multiple types
072b3e4
@sreya
add support for private templates
205c36c
@sreya
go.mod
ba32928
@sreya
Merge branch 'main' into resource_acl_list
5c6344f
@sreya
fix rbac merge woes
ef15908
@sreya
update migration
8ab5200
@sreya
fix workspaces_test
c040e8e
@sreya
remove sqlx
1f4ceee
@sreya
fix audit
7cc71e1
@sreya
fix lint
131d5ed
@sreya
Revert "remove sqlx"
8c3ee6a 
This reverts commit 1f4ceee.
@sreya
add test for list templates
fe2af91
@sreya
fix error msg
0218c4e
@sreya
fix sqlx woes
6883106
@sreya
fix lint
4fbd9be
@sreya
fix audit
c96a6ca
@sreya
make gen
57ba8b3
@sreya
Merge branch 'main' into resource_acl_list
c66d247
bpmct
bpmct reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's flag the user-facing behavior so we can QA it over the next few days: #4364

@BrunoQuaresma
Copy link
Collaborator

Let's flag the user-facing behavior so we can QA it over the next few days: #4364

Since we don't have users with licenses yet, it should be OK to not flag IMO.

@coder coder deleted a comment from BrunoQuaresma Oct 7, 2022
@coder coder deleted a comment from BrunoQuaresma Oct 7, 2022
This was referenced Oct 7, 2022
Closed
Closed
Closed
@sreya sreya merged commit 3120c94 into main Oct 10, 2022
@sreya sreya deleted the groups branch October 10, 2022 20:37
@sreya sreya mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpmct bpmct bpmct left review comments

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

@sreya sreya

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding specific users to specific templates
6 participants
@sreya @ammario @BrunoQuaresma @kylecarbs @bpmct @Emyrk