docs: Update Docker docs and docker-compose, mention group-add
#4237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Sep 28, 2022
bpmct
reviewed
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was prompted by a discussion on Discord.
It's most likely never the case that our Docker images
coderuser (1000:1000) will have write permissions on the Docker socket. For this reason we mention--group-addin the CLI commands and add a commentedgroup_add:to ourdocker-compose.yaml.Hopefully this will help users resolve permission errors on their docker sockets and avoid cases where they have to manually
chownit.An alternative/additional step we could take is to run our image as
rootwith an entrypoint that 1) ensures socket permissions and 2) drops privileges viagosu/su-exec.