chore: Use Vite as build tool #4239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Sep 28, 2022
presleyp
approved these changes
Sep 28, 2022
|
@kylecarbs For now, I'm keeping Webpack + related config to make it easier to roll back if we need it. Just being extra cautious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running some build comparisons with Vite and Webpack for prod.
yarn build 13.41s user 1.14s system 220% cpu 6.598 totalyarn vite build 32.33s user 1.84s system 158% cpu 21.545 totalVite, surprisingly, does not perform well as webpack on build BUT it is WAY easier to set up. No need for extra files or a lot of plugins.
For now, I'm keeping Webpack + related config to make it easier to roll back if we need it.