feat: coder ls should show possible columns to filter by
#4240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Sep 28, 2022
johnstcn
reviewed
Sep 28, 2022
Comment on lines
+88
to
+94
| if me { | ||
| myUser, err := client.User(cmd.Context(), codersdk.Me) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| filter.Owner = myUser.Username | ||
| } |
There was a problem hiding this comment.
review: this might be a left-over piece of a merge conflict
Comment on lines
+131
to
+139
| v := reflect.Indirect(reflect.ValueOf(displayWorkspaces)) | ||
| availColumns, err := cliui.TypeToTableHeaders(v.Type().Elem()) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| for i, s := range availColumns { | ||
| availColumns[i] = strings.Replace(s, " ", "_", -1) | ||
| } | ||
| columnString := strings.Join(availColumns[:], ", ") |
There was a problem hiding this comment.
This is good, but since we'd probably want to use this in multiple commands it would be better served as a function in the cliui package that accepts any:
func TableHeaders(t any) ([]string, error) {
v := reflect.Indirect(reflect.ValueOf(t))
return cliui.TypeToTableHeaders(v.Type())
}
func FormatColumnNames(columns []string) string {
out := strings.Join(columns[:], ", ")
out = strings.ReplaceAll(out, " ", "_")
return out
}which could be called like
columns, err := cliui.TableHeaders(workspaceListRow{})
if err != nil {
panic(err)
}
columnString := cliui.FormatColumnNames(columns)This would also remove the need for having a global(ish) var for the output
There was a problem hiding this comment.
future fix ideaaa :D
johnstcn
added a commit
that referenced
this pull request
Sep 29, 2022
johnstcn
added a commit
that referenced
this pull request
Sep 29, 2022
johnstcn
added a commit
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves feature request for #1432