Skip to content

feat: add rich parameters #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

feat: add rich parameters #4311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c7e8d4e
Add schema
kylecarbs Sep 29, 2022
c6cda84
Deprecate parse
kylecarbs Sep 29, 2022
d242523
Rename parameter routes to deprecated
kylecarbs Sep 29, 2022
e71711c
Add parameter parsing to builds
kylecarbs Sep 29, 2022
4cd5826
Add parameter parsing to the Terraform provider
kylecarbs Sep 30, 2022
120a70a
Add deprecated key to codersdk parameter values
kylecarbs Sep 30, 2022
a414314
Add new template parameter endpoint
kylecarbs Sep 30, 2022
bc6c788
Begin to integrate parameter validation
kylecarbs Sep 30, 2022
c85f7d2
Add new frontend for rendering parameters
kylecarbs Oct 2, 2022
5d9ac64
Add parameters to the create screen
kylecarbs Oct 2, 2022
1d934e8
Merge branch 'main' into parameter
kylecarbs Oct 2, 2022
b9dcfc3
Show parameters in the UI
kylecarbs Oct 3, 2022
367c913
Merge branch 'main' into parameter
kylecarbs Oct 25, 2022
022eec8
Add deprecated parameter schema
kylecarbs Oct 25, 2022
1e05960
Update deprecated parameter name in CLI
kylecarbs Oct 27, 2022
63572a5
Merge branch 'main' into parameter
kylecarbs Nov 5, 2022
51b3d47
Merge branch 'main' into parameter
kylecarbs Nov 30, 2022
a864d46
Fix some test things
kylecarbs Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Show parameters in the UI
  • Loading branch information
@kylecarbs
kylecarbs committed Oct 3, 2022
commit b9dcfc3a657e61e19d3628e579c087bd81d88f5d
2 changes: 1 addition & 1 deletion site/src/components/UserAutocomplete/UserAutocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const UserAutocomplete: FC<UserAutocompleteProps> = ({

const handleFilterChange = debounce((event: ChangeEvent<HTMLInputElement>) => {
sendSearch("SEARCH", { query: event.target.value })
}, 1000)
}, 250)

return (
<Autocomplete
Expand Down
13 changes: 5 additions & 8 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export const CreateWorkspacePageView: FC<React.PropsWithChildren<CreateWorkspace
props,
) => {
const { t } = useTranslation("createWorkspacePage")

const [deprecatedParameterValues, setDeprecatedParameterValues] = useState<
Record<string, string>
>({})
Expand Down Expand Up @@ -139,7 +138,7 @@ export const CreateWorkspacePageView: FC<React.PropsWithChildren<CreateWorkspace
/>

{props.loadingTemplateSchema && <Loader />}
{props.selectedTemplate && props.templateSchema && (
{props.selectedTemplate && props.templateSchema && props.templateParameters && (
<>
<TextField
{...getFieldHelpers("name")}
Expand Down Expand Up @@ -179,6 +178,10 @@ export const CreateWorkspacePageView: FC<React.PropsWithChildren<CreateWorkspace
</Stack>
)}

{props.templateParameters.map((parameter) => (
<WorkspaceParameter templateParameter={parameter} key={parameter.name} />
))}

{props.workspaceQuota && (
<WorkspaceQuota
quota={props.workspaceQuota}
Expand All @@ -195,12 +198,6 @@ export const CreateWorkspacePageView: FC<React.PropsWithChildren<CreateWorkspace
/>
</>
)}

{props.selectedTemplate &&
props.templateParameters &&
props.templateParameters.map((parameter) => (
<WorkspaceParameter templateParameter={parameter} key={parameter.name} />
))}
</Stack>
</form>
</FullPageForm>
Expand Down