fix: Add isFirst check before err check #4326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing TestBlockNonBrowser to hang and fail.
|
Force merging this because CI is in shambles right now! |
mafredri
reviewed
Oct 3, 2022
| if isFirst { | ||
| if res.StatusCode == http.StatusConflict { | ||
| if err != nil && res.StatusCode == http.StatusConflict { |
There was a problem hiding this comment.
Should this be err == nil? Thinking this will still have the potential nil pointer deref if err != nil?
There was a problem hiding this comment.
Ahh, you're correct. I'll fix this now in another PR. I merged due to panic of main being busted!
There was a problem hiding this comment.
It seems the error isn't nil there actually, so a weird case. I'm just going to check for the status code, then it should be fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing TestBlockNonBrowser to hang and fail.