Improve getting started #4346
Closed
Improve getting started #4346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only looks inside quickstart directory now
Emyrk
reviewed
Oct 3, 2022
Comment on lines
+39
to
+41
| // WalkForExamples will walk recursively through the examples directory and call | ||
| // exampleDirectory() on each directory that contains a main.tf file. | ||
| func WalkForExamples(files fs.FS, rootDir string, exampleDirectory func(path string)) error { |
There was a problem hiding this comment.
It now will follow nested directories until it hits a main.tf file. So we can create w/e structure we want for these files.
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR addresses step 1 of #4201, and separates example templates from quickstarts.
the
quickstartdirectory houses subdirectories for each type of compute, containers and virtual machines. within these subdirs are the example templates for each cloud/infra.with the help of @Emyrk, the
examples.gotest is now more generic and lists all templates in thequickstartsubdirs:alternatively the
examplesdirectory is intended for more specific, bespoke template examples. we can extendexamples_test.goto include theexamplesdir if need be.i removed the
baretemplate since it was not usable out-of-the-box, and thegcp-vm-container,docker-code-servertemplates because they were duplicates of existing templates. feedback appreciated.Coder templates init
New templates listed when running
templates init. Used to list 15 templates, now lists 9