fix: Test flake when installing yarn dependencies on MacOS #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 67.99% 68.26% +0.26%
==========================================
Files 156 159 +3
Lines 9046 9226 +180
Branches 73 73
==========================================
+ Hits 6151 6298 +147
- Misses 2289 2308 +19
- Partials 606 620 +14
Continue to review full report at Codecov.
|
|
Thanks for the quick review @kylecarbs ! I'll test this out w/ the other dependabot PRs - and then move on to investigating the |
greyscaled
approved these changes
Mar 14, 2022
Co-authored-by: G r e y <vapurrmaid@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #433 - a test flake in E2E (intermittent
ESOCKETTIMEDOUTerrors on MacOS).The main issue is that, occasionally, for very large dependencies (like
@material-ui/icons) - yarn can actually time out! We researched this in-depth in v1: https://github.com/coder/m/pull/10040 and fixed it successfully there, by increasing the timeout for yarn.However, this also highlighted the fact that our
node_modulescaching behavior wasn't correct - we should very rarely see a timeout issue like this, because@material-ui/iconsshould be cached.It turns out that we weren't falling back to the latest cached
node_modulesif there was a miss - so anytime the lock file changed, we'd invalidate the cache, and not restore the previous one. This can be improved by using therestore-keysparameter of the@actions/cache... and in fact we already do this for thegodependencies.So this fix does two things:
@material-ui/icons(and other large dependencies)ESOCKETTIMEDOUTerrors