Skip to content

feat: add experimental flag #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2022
Merged

feat: add experimental flag #4364

merged 5 commits into from
Oct 4, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Oct 4, 2022

No description provided.

@f0ssel f0ssel requested a review from a team as a code owner October 4, 2022 19:16
@f0ssel f0ssel requested review from Kira-Pilot and removed request for a team October 4, 2022 19:16
@f0ssel f0ssel requested review from bpmct and deansheather October 4, 2022 19:22
@f0ssel f0ssel enabled auto-merge (squash) October 4, 2022 19:35
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how we're planning on using this on the FE. Is this just for entitlements?

@f0ssel f0ssel merged commit ffbaa93 into main Oct 4, 2022
@f0ssel f0ssel deleted the f0ssel/ff branch October 4, 2022 19:45
@f0ssel
Copy link
Contributor Author

f0ssel commented Oct 4, 2022

@Kira-Pilot it's basically a global flag for the deployment, and since we were already fetch the license at the top level of the app I wanted to piggyback off entitlements to avoid another round trip. I avoided putting it in buildinfo because that info comes from the binary and this experimental flag is set at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants