Skip to content

fix: Remove audit warning if unlicensed #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix: Remove audit warning if unlicensed #4387

merged 1 commit into from
Oct 6, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #4383.

@kylecarbs kylecarbs requested a review from f0ssel October 6, 2022 13:22
@kylecarbs kylecarbs self-assigned this Oct 6, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) October 6, 2022 13:23
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you're triple sure this doesn't give every unlicensed deployment audit logging for free then LGTM 👍

Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, it wasn't clear to me in the code that audit logging was on by default.

@kylecarbs
Copy link
Member Author

@f0ssel we should probably have better testing around these warnings anyways, since it's a big no-no to display any if unlicensed (and maybe we should just change the code to do that).

@kylecarbs kylecarbs disabled auto-merge October 6, 2022 13:48
@kylecarbs kylecarbs merged commit d275331 into main Oct 6, 2022
@kylecarbs kylecarbs deleted the auditfix branch October 6, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License issue warning after update to 0.9.4 (audit logging is enabled)
3 participants