Skip to content

refactor: Move runtime dependencies out of devDependencies #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

bryphe-coder
Copy link
Contributor

@presleyp noticed that we have a lot of dependencies listed as devDependencies that should be actual dependencies - this PR moves them to the appropriate category.

Thanks for catching this @presleyp !

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #439 (28ba44d) into main (cadc298) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   68.11%   68.26%   +0.15%     
==========================================
  Files         159      159              
  Lines        9226     9226              
  Branches       73       73              
==========================================
+ Hits         6284     6298      +14     
+ Misses       2319     2308      -11     
+ Partials      623      620       -3     
Flag Coverage Δ
unittest-go-macos-latest 62.80% <ø> (+0.10%) ⬆️
unittest-go-ubuntu-latest 67.55% <ø> (-0.07%) ⬇️
unittest-go-windows-2022 62.19% <ø> (-0.18%) ⬇️
unittest-js 64.07% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/dial.go 75.43% <0.00%> (-7.02%) ⬇️
codersdk/provisionerdaemons.go 58.46% <0.00%> (-3.08%) ⬇️
provisioner/echo/serve.go 55.00% <0.00%> (-2.50%) ⬇️
coderd/provisionerdaemons.go 57.06% <0.00%> (-0.55%) ⬇️
provisionerd/provisionerd.go 79.59% <0.00%> (+1.28%) ⬆️
peer/conn.go 81.07% <0.00%> (+4.09%) ⬆️
provisionersdk/serve.go 43.24% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadc298...28ba44d. Read the comment docs.

@bryphe-coder
Copy link
Contributor Author

Thanks for the review @vapurrmaid !

@bryphe-coder bryphe-coder merged commit 5e4d88a into main Mar 15, 2022
@bryphe-coder bryphe-coder deleted the bryphe/refactor/fix-dependencies branch March 15, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants