feat: Add tunnel by default #4399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
approved these changes
Oct 6, 2022
cli/server_test.go
Outdated
| @@ -127,6 +129,7 @@ func TestServer(t *testing.T) { | |||
| "server", | |||
| "--in-memory", | |||
| "--address", ":0", | |||
| "--access-url", "example.com", | |||
| "--access-url", "localhost:3000/", | |||
|
(cc @endingwithali this affects docs) |
If an access URL is not specified, we will always tunnel. This is from community-member feedback who exclaimed that it's confusing having the default for `coder server` display a warning message, and I agree. There is very little (maybe none) in running `coder server` without tunnel and without an access URL, so this seems like overall a much better UX.
5882d6e to
ef8cb8a
Compare
|
yes! auto setting tunnel is a great idea. :) to 100% clarify - when running coder without an access url, you wont need to edit coder.env before running coder |
|
Great change 👍 |
bpmct
approved these changes
Oct 6, 2022
| @@ -4,7 +4,7 @@ You can install and run Coder using the official Docker images published on [Git | |||
|
|
|||
| Docker is required. See the [official installation documentation](https://docs.docker.com/install/). | |||
|
|
|||
| ## Run Coder with built-in database and tunnel (quick) | |||
| ## Run Coder with the built-in database (quick) | |||
There was a problem hiding this comment.
Let's still mention we're using the tunnel here, both are configured here based on the lack of flags.
|
I assume this change won't break existing deployments? |
Co-authored-by: Ben Potter <ben@coder.com>
Co-authored-by: Ben Potter <ben@coder.com>
|
@ammario it won't unless they aren't specifying an access URL, but even then it won't break them unless they are air-gapped and the tunnel will fail with a message indicating that an access URL should be specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an access URL is not specified, we will always tunnel.
This is from community-member feedback who exclaimed that it's confusing having the default for
coder serverdisplay a warning message, and I agree.There is very little (maybe none) in running
coder serverwithout tunnel and without an access URL, so this seems like overall a much better UX.